Quote row type field names #1963
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
martint
force-pushed
the
row-reserved-name
branch
4 times, most recently
from
65e1afc
to
3fab865
Compare
kokosing
approved these changes
Nov 6, 2019
| @@ -319,6 +319,11 @@ public void testRowSubscript() | |||
|
|
|||
| // Row subscript in join condition | |||
| assertQuery("SELECT n.name, r.name FROM nation n JOIN region r ON ROW (n.name, n.regionkey)[2] = ROW (r.name, r.regionkey)[2] ORDER BY n.name LIMIT 1", "VALUES ('ALGERIA', 'AFRICA')"); | |||
|
|
|||
| // Subscript over field named after reserved keyword | |||
| assertQuery( | |||
There was a problem hiding this comment.
I think we should have a dedicated test for planner (TestPlanner?). There is no point to run this test for all the connectors.
There was a problem hiding this comment.
IIRC the issue occurs when distributing plan fragments to workers, so this must run in distributed mode.
presto-tests/src/main/java/io/prestosql/tests/AbstractTestQueries.java
Outdated
Show resolved
Hide resolved
martint
force-pushed
the
row-reserved-name
branch
from
3fab865
to
b5a30ab
Compare
dain
approved these changes
Nov 6, 2019
| @@ -319,6 +319,11 @@ public void testRowSubscript() | |||
|
|
|||
| // Row subscript in join condition | |||
| assertQuery("SELECT n.name, r.name FROM nation n JOIN region r ON ROW (n.name, n.regionkey)[2] = ROW (r.name, r.regionkey)[2] ORDER BY n.name LIMIT 1", "VALUES ('ALGERIA', 'AFRICA')"); | |||
|
|
|||
| // Subscript over field named after reserved keyword | |||
| assertQuery( | |||
There was a problem hiding this comment.
IIRC the issue occurs when distributing plan fragments to workers, so this must run in distributed mode.
martint
force-pushed
the
row-reserved-name
branch
from
b5a30ab
to
f502d5a
Compare
it already is used to test distribution-related things, eg |
Names can be reserved SQL keywords, so we need to quote them to avoid issues when deserializing plans on workers.
TypeSignature is used for encoding the identity of a type, which is then parsed (for now) using the SQL parser. Since some fields names might collide with SQL reserved words, we need to quote them.
martint
force-pushed
the
row-reserved-name
branch
from
f502d5a
to
9adf159
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since row type field names can match reserved SQL keywords, names
need to be quoted when rendering them.
Fixes #1962